Hello Russell, On Tue, 02 Apr 2024 16:51:48 +0100 "Russell King (Oracle)" <rmk+kernel@xxxxxxxxxxxxxxx> wrote: > Use the newly introduced pcs_init() and pcs_exit() operations to > create and destroy the PCS instance at a more appropriate moment during > the driver lifecycle, thereby avoiding publishing a network device to > userspace that has not yet finished its PCS initialisation. > > There are other similar issues with this driver which remain > unaddressed, but these are out of scope for this patch. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> Thanks for addressing this, Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>