Re: [PATCH v8 3/7] spmi: pmic-arb: Fix some compile warnings about members not being described

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/04/2024 14:07, Abel Vesa wrote:
Fix the following compile warnings:

  warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb'
  warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb'
  warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb'
  warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data'
  warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data'

Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
---
  drivers/spmi/spmi-pmic-arb.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 9ed1180fe31f..704fd4506971 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -132,6 +132,8 @@ struct apid_data {
   * @wr_base:		on v1 "core", on v2 "chnls"    register base off DT.
   * @intr:		address of the SPMI interrupt control registers.
   * @cnfg:		address of the PMIC Arbiter configuration registers.
+ * @core:		core register base for v2 and above only (see above)
+ * @core_size:		core register base size
   * @lock:		lock to synchronize accesses.
   * @channel:		execution environment channel to use for accesses.
   * @irq:		PMIC ARB interrupt.
@@ -144,6 +146,7 @@ struct apid_data {
   * @apid_count:		on v5 and v7: number of APIDs associated with the
   *			particular SPMI bus instance
   * @mapping_table:	in-memory copy of PPID -> APID mapping table.
+ * @mapping_table_valid:bitmap containing valid-only periphs
   * @domain:		irq domain object for PMIC IRQ domain
   * @spmic:		SPMI controller object
   * @ver_ops:		version dependent operations.
@@ -232,6 +235,7 @@ static inline void pmic_arb_set_rd_cmd(struct spmi_pmic_arb *pmic_arb,
/**
   * pmic_arb_read_data: reads pmic-arb's register and copy 1..4 bytes to buf
+ * @pmic_arb:	the SPMI PMIC arbiter
   * @bc:		byte count -1. range: 0..3
   * @reg:	register's address
   * @buf:	output parameter, length must be bc + 1
@@ -246,6 +250,7 @@ pmic_arb_read_data(struct spmi_pmic_arb *pmic_arb, u8 *buf, u32 reg, u8 bc)
/**
   * pmic_arb_write_data: write 1..4 bytes from buf to pmic-arb's register
+ * @pmic_arb:	the SPMI PMIC arbiter
   * @bc:		byte-count -1. range: 0..3.
   * @reg:	register's address.
   * @buf:	buffer to write. length must be bc + 1.


Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux