On Tue, Apr 02, 2024 at 08:06:27PM +0200, Krzysztof Kozlowski wrote: > On 02/04/2024 14:30, Siddharth Vadapalli wrote: > > On Tue, Apr 02, 2024 at 02:08:32PM +0200, Krzysztof Kozlowski wrote: > >> On 02/04/2024 12:57, Siddharth Vadapalli wrote: > >>> The CTRLMMR_MAC_IDx registers within the CTRL_MMR space of TI's AM62p SoC > >>> contain the MAC Address programmed in the eFuse. Add compatible for > >>> allowing the CPSW driver to obtain a regmap for the CTRLMMR_MAC_IDx > >>> registers within the System Controller device-tree node. The default MAC > >>> Address for the interface corresponding to the first MAC port will be set > >>> to the value programmed in the eFuse. > >>> > >>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx> > >>> --- > >>> > >>> This patch is based on linux-next tagged next-20240402. > >> > >> Where is the DTS using it? > > > > The current implementation in the device-tree for older TI K3 SoCs is as > > follows: > > > > cpsw_port1: port@1 { > > reg = <1>; > > ti,mac-only; > > label = "port1"; > > phys = <&phy_gmii_sel 1>; > > mac-address = [00 00 00 00 00 00]; > > ti,syscon-efuse = <&wkup_conf 0x200>; > > }; > > > > The "ti,syscon-efuse" property passes the reference to the System > > Controller node as well as the offset to the CTRLMMR_MAC_IDx registers > > within the CTRL_MMR space. > > Please reference upstream DTS or lore link to patch under review. An example of the existing implementation in the device-tree for AM64x is: https://github.com/torvalds/linux/blob/d4e8c8ad5d14ad51ed8813442d81c43019fd669d/arch/arm64/boot/dts/ti/k3-am64-main.dtsi#L697 It uses: ti,syscon-efuse = <&main_conf 0x200>; and "main_conf" node is defined at: https://github.com/torvalds/linux/blob/d4e8c8ad5d14ad51ed8813442d81c43019fd669d/arch/arm64/boot/dts/ti/k3-am64-main.dtsi#L40 Regards, Siddharth.