On Thu, Mar 28, 2024 at 04:01:02PM -0500, Rob Herring wrote: > > On Thu, 28 Mar 2024 12:19:54 -0300, Fabio Estevam wrote: > > From: Fabio Estevam <festevam@xxxxxxx> > > > > Since commit 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint > > property verification") the ov2680 no longer probes on a imx7s-warp7: > > > > ov2680 1-0036: error -EINVAL: supported link freq 330000000 not found > > ov2680 1-0036: probe with driver ov2680 failed with error -22 > > > > Fix it by passing the required 'link-frequencies' property as > > recommended by: > > > > https://www.kernel.org/doc/html/v6.9-rc1/driver-api/media/camera-sensor.html#handling-clocks > > > > Cc: stable@xxxxxxxxxxxxxxx > > Fixes: 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification") > > Signed-off-by: Fabio Estevam <festevam@xxxxxxx> > > --- > > arch/arm/boot/dts/nxp/imx/imx7s-warp.dts | 1 + > > 1 file changed, 1 insertion(+) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y nxp/imx/imx7s-warp.dtb' for 20240328151954.2517368-1-festevam@xxxxxxxxx: > > arch/arm/boot/dts/nxp/imx/imx7s-warp.dtb: camera@36: port:endpoint: Unevaluated properties are not allowed ('clock-lanes', 'data-lanes', 'link-frequencies' were unexpected) > from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml# So it sounds like that the bindings doc needs an update to include 'link-frequencies'? Shawn