Hey, On Tue, Apr 02, 2024 at 04:00:32PM +0200, Steen Hegelund wrote: > On Mon, 2024-04-01 at 17:37 +0200, Krzysztof Kozlowski wrote: > > [Some people who received this message don't often get email from > > krzk@xxxxxxxxxx. Learn why this is important at > > https://aka.ms/LearnAboutSenderIdentification ;] > > > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > Correct the reg address of mdio node to match unit address. Assume > > the > > reg is not correct and unit address was correct, because there is > > alerady node using the existing reg 0x110102d4. > > > > sparx5.dtsi:443.25-451.5: Warning (simple_bus_reg): > > /axi@600000000/mdio@6110102f8: simple-bus unit address format error, > > expected "6110102d4" > > > > Fixes: d0f482bb06f9 ("arm64: dts: sparx5: Add the Sparx5 switch > > node") > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > > > --- > > > > Not tested on hardware > > --- > > arch/arm64/boot/dts/microchip/sparx5.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > index 24075cd91420..5d820da8c69d 100644 > > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > @@ -447,7 +447,7 @@ mdio2: mdio@6110102f8 { > > pinctrl-names = "default"; > > #address-cells = <1>; > > #size-cells = <0>; > > - reg = <0x6 0x110102d4 0x24>; > > + reg = <0x6 0x110102f8 0x24>; > > }; > > > > mdio3: mdio@61101031c { > > -- > > 2.34.1 > > > > I did a check of our current Sparx5 EVBs and none of them uses > controller 2 in any revision, so this is probably why it has not come > up before, so as it stands we have no platform to test this change on > currently. > > Besides that the change looks good to me. > > Best Regards > Steen > > Reviewed-by: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx> Are you okay with the rest of the series, or have you only looked at this one patch?
Attachment:
signature.asc
Description: PGP signature
