Device tree best practice is to disable any external interface in the dtsi and just enable them if needed in the device tree. Thus, disable both ethernet ports by default and just enable the one used by the EVM in its device tree. There is no functional change. Signed-off-by: Michael Walle <mwalle@xxxxxxxxxx> --- This should also be true for all the other SoCs. But I don't wanted to touch all the (older) device trees. j722s is pretty new, so there we should get it right. --- arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 5 +---- arch/arm64/boot/dts/ti/k3-j722s.dtsi | 8 ++++++++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts index d045dc7dde0c..afe7f68e6a4b 100644 --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts @@ -224,14 +224,11 @@ cpsw3g_phy0: ethernet-phy@0 { }; &cpsw_port1 { + status = "okay"; phy-mode = "rgmii-rxid"; phy-handle = <&cpsw3g_phy0>; }; -&cpsw_port2 { - status = "disabled"; -}; - &main_gpio1 { status = "okay"; }; diff --git a/arch/arm64/boot/dts/ti/k3-j722s.dtsi b/arch/arm64/boot/dts/ti/k3-j722s.dtsi index c75744edb143..d0451e6e7496 100644 --- a/arch/arm64/boot/dts/ti/k3-j722s.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j722s.dtsi @@ -83,6 +83,14 @@ &inta_main_dmss { ti,interrupt-ranges = <7 71 21>; }; +&cpsw_port1 { + status = "disabled"; +}; + +&cpsw_port2 { + status = "disabled"; +}; + &oc_sram { reg = <0x00 0x70000000 0x00 0x40000>; ranges = <0x00 0x00 0x70000000 0x40000>; -- 2.39.2