On 3/27/24 15:43, Animesh Agarwal wrote: > Convert the ahci-da850 bindings to DT schema. > > Signed-off-by: Animesh Agarwal <animeshagarwal28@xxxxxxxxx> Krzysztof, Rob, Are you OK with this patch ? > > --- > Changes in v3: > - Fixed line length issue on line 20 > - Removed unneccessary '|' character > Changes in v2: > - Added description for reg property items. > --- > .../devicetree/bindings/ata/ahci-da850.txt | 18 --------- > .../bindings/ata/ti,da850-ahci.yaml | 39 +++++++++++++++++++ > 2 files changed, 39 insertions(+), 18 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.txt > create mode 100644 Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml > > diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Documentation/devicetree/bindings/ata/ahci-da850.txt > deleted file mode 100644 > index 5f8193417725..000000000000 > --- a/Documentation/devicetree/bindings/ata/ahci-da850.txt > +++ /dev/null > @@ -1,18 +0,0 @@ > -Device tree binding for the TI DA850 AHCI SATA Controller > ---------------------------------------------------------- > - > -Required properties: > - - compatible: must be "ti,da850-ahci" > - - reg: physical base addresses and sizes of the two register regions > - used by the controller: the register map as defined by the > - AHCI 1.1 standard and the Power Down Control Register (PWRDN) > - for enabling/disabling the SATA clock receiver > - - interrupts: interrupt specifier (refer to the interrupt binding) > - > -Example: > - > - sata: sata@218000 { > - compatible = "ti,da850-ahci"; > - reg = <0x218000 0x2000>, <0x22c018 0x4>; > - interrupts = <67>; > - }; > diff --git a/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml > new file mode 100644 > index 000000000000..ce13c76bdffb > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ata/ti,da850-ahci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI DA850 AHCI SATA Controller > + > +maintainers: > + - Animesh Agarwal <animeshagarwal28@xxxxxxxxx> > + > +properties: > + compatible: > + const: ti,da850-ahci > + > + reg: > + items: > + - description: Address and size of the register map as defined by the AHCI 1.1 standard. > + - description: > + Address and size of Power Down Control Register (PWRDN) for enabling/disabling the SATA clock > + receiver. > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + sata@218000 { > + compatible = "ti,da850-ahci"; > + reg = <0x218000 0x2000>, <0x22c018 0x4>; > + interrupts = <67>; > + }; -- Damien Le Moal Western Digital Research