On Mon, Apr 1, 2024 at 10:34 AM Deepak Gupta <debug@xxxxxxxxxxxx> wrote: > > On Mon, Apr 1, 2024 at 2:48 AM Muhammad Usama Anjum > <usama.anjum@xxxxxxxxxxxxx> wrote: > > > > >>> Signed-off-by: Deepak Gupta <debug@xxxxxxxxxxxx> > > >>> --- > > >>> tools/testing/selftests/riscv/Makefile | 2 +- > > >>> tools/testing/selftests/riscv/cfi/Makefile | 10 + > > >>> .../testing/selftests/riscv/cfi/cfi_rv_test.h | 85 ++++ > > >>> .../selftests/riscv/cfi/riscv_cfi_test.c | 91 +++++ > > >>> .../testing/selftests/riscv/cfi/shadowstack.c | 376 ++++++++++++++++++ > > >>> .../testing/selftests/riscv/cfi/shadowstack.h | 39 ++ > > >> Please add generated binaries in the .gitignore files. > > > > > > hmm... > > > I don't see binary as part of the patch. Which file are you referring > > > to here being binary? > > shadowstack would be generated by the build. Create a .gitignore file and > > add it there. For example, look at > > tools/testing/selftests/riscv/vector/.gitignore to understand. > > It's `shadowstack.c` (a C source file) and not a binary file. Nevermind. I think what you want me to do is add a rule in `.gitignore`. I was thinking otherwise (that somehow you're seeing a binary file in patch set). Thanks. Will do that in the next iteration.
