On Mon, 1 Apr 2024 12:04:55 +0100 Conor Dooley <conor@xxxxxxxxxx> wrote: > On Sat, Mar 30, 2024 at 04:10:12PM +0000, Jonathan Cameron wrote: > > On Fri, 29 Mar 2024 15:49:26 +0000 > > Conor Dooley <conor@xxxxxxxxxx> wrote: > > > > > On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@xxxxxxx wrote: > > > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx> > > > > > > > > Add bindings for ICM-42688-P chip. > > > > > > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx> > > > > > > My initial thought was that you're missing a sign-off, but is > > > "inv.git-commit@xxxxxxx" some system you have to bypass corporate email > > > garbage? > > > > Common enough setup, as long as the From: line matches the sign-off, git will > > ignore the email address used to send it when the patch is applied. > > Yeah, I know how it works, I do it all the time. Even found, or rather > caused, a b4 bug where it would use the sending email in the eventual > commit rather than the author: > https://lore.kernel.org/tools/20230310192652.ymac3w2lucfdf34p@meerkat.local/ > > I'm just double checking that there's not a missing signoff. When I've > seen these corp-email-bypass accounts before people set a proper "from" > in git send-email so there's a name in it: "A Dev <inv.git-commit@xxxxxxx>" > Ah. Got it now :) I guess it depends on how their weird setup wires everything up! Jonathan
