On 26/03/2024 21:41, Eric Woudstra wrote: > Hi Rob, > > On 3/26/24 20:29, Rob Herring wrote: >> On Tue, Mar 26, 2024 at 05:23:04PM +0100, Eric Woudstra wrote: >>> Add the Airoha EN8811H 2.5 Gigabit PHY. >>> >>> The en8811h phy can be set with serdes polarity reversed on rx and/or tx. >>> >>> Signed-off-by: Eric Woudstra <ericwouds@xxxxxxxxx> >> >> Did you change something or forget to add Krzysztof's Reviewed-by? > > Nothing has changed in this commit. I was wondering if I should do this, > so I should have added the Reviewed-by Krzysztof. > Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Please carefully read above guideline. Entire. Best regards, Krzysztof
