On Thu, 28 Mar 2024 17:24:17 +0100 Andrew Lunn <andrew@xxxxxxx> wrote: > > +static int tps23881_flash_fw_part(struct i2c_client *client, > > + const char *fw_name, > > + const struct tps23881_fw_conf *fw_conf) > > Does the device actually have flash? Or is this just downloading to > SRAM? It is downloading to SRAM. > > > +{ > > + const struct firmware *fw = NULL; > > + int i, ret; > > + > > + ret = request_firmware(&fw, fw_name, &client->dev); > > + if (ret) > > + return ret; > > + > > + dev_info(&client->dev, "Flashing %s\n", fw_name); > > If this is a one-time thing whenever there is a new firmware version > dropped into /lib/firmware, this would be O.K. However, if this > happens every boot, i would use dev_dbg(). Ok I will change to dev_dbg then. Thanks! Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com