On 09/02/15 16:13, Andrew Lunn wrote: > On Mon, Feb 09, 2015 at 01:50:37PM +0200, Tomi Valkeinen wrote: >> On 06/02/15 05:10, Andrew Lunn wrote: >>> On Tue, Jan 27, 2015 at 02:59:19PM +0100, Andrew Lunn wrote: >>>> This patchset is a driver for the TI tlc59116 16 Channel i2c LED >>>> driver and tlc59108 8 Channel i2c LED driver. This driver is used on >>>> the Belkin WRT1900AC access point and the C code is derived from code >>>> Belkin contributed to OpenWRT. However it has been extensively >>>> re-written, and a device tree binding added to replace platform data. >>> >>> Hi Bryan >>> >>> Do you have any further comments on this driver? Are you likely to >>> queue it up for the next merge window? >> >> Hi Andrew, >> >> You didn't comment anything on my and Peter's questions on v5 thread >> about this being a PWM driver. > > Hi Tomi > > I don't comment, because it is not our decision to make any more. We > have been around this argument many times, so we are not going to > resolve it. The LED and PWM maintainers need to decide, not us. Well, I wasn't asking for decisions. I asked what are the technical differences between the options. If this driver would be implemented as a PWM driver, and you'd use pwm-leds, how would that affect your use case? If I'm not mistaken, the only argument so far you've given was that the device cannot implement the pwm_config() call correctly, but Peter argued that it doesn't matter, other PWM devices cannot do that either. I want the driver to work for all the users, and as I'm not that familiar with leds and pwms I need to ask these questions. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
