Hi Jonathan,
This is the result of the brief discussion we had in the RFC [1].
Patches 2 to 5 from Paul's series to bring output buffer support to
DMA buffers [2].
Note that the original DMA patch 4 ("iio: buffer-dmaengine: Support
specifying buffer direction") also had changes for the axi-adc as it
used devm_iio_dmaengine_buffer_setup(). However, when that was converted
to the backend framework, we started to use iio_dmaengine_buffer_alloc()
and default is INPUT so no need for any change.
I did gave it a try on beginning to support extending IIO channels
(chan_spec) from backend's. For now, we just need to do it for the
extended info and honestly, IMHO, I don't think the result to be
horrible :). The only thing that I don't like much is the call to
iio_device_set_drvdata() in iio_backend_extend_chan_spec(). Long story
short, I know it's likely to break so maybe we should have a proper
solution right from the beginning. But see the comment I have in there.
I did thought in a solution that should work but you may have a better
idea.
Also note the main reason to come up with the iio_backend_ext_info_set()
and iio_backend_ext_info_get() helpers is not to allow starting having
these from backends. I was even thinking in just passing the callbacks
from the frontend to iio_backend_extend_chan_spec() but I kind of prefer
this way. We may still need at some point to allow frontends to have full
control and have their callbacks in the attributes. But for now, I'm not
even allowing for backends to append a channel ext_info so i would say to
worry about that when such a scenario pops up.
I would also prefer for iio_backend_ext_info_set() and
iio_backend_ext_info_get() to be static but that would make the code more
complex than it needs to be (we would have to kmemdup() the backends
ext_info and assign the callbacks) so I went this way.
[1]: https://lore.kernel.org/linux-iio/20240216-iio-backend-axi-dds-v1-0-22aed9fb07a1@xxxxxxxxxx/
[2]: https://lore.kernel.org/linux-iio/20230807112113.47157-1-paul@xxxxxxxxxxxxxxx/
---
Nuno Sa (6):
iio: buffer: add helper for setting direction
dt-bindings: iio: dac: add bindings doc for AXI DAC driver
dt-bindings: iio: dac: add bindings doc for AD9739A
iio: backend: add new functionality
iio: dac: add support for AXI DAC IP core
iio: dac: support the ad9739a RF DAC
Paul Cercueil (4):
iio: buffer-dma: Rename iio_dma_buffer_data_available()
iio: buffer-dma: Enable buffer write support
iio: buffer-dmaengine: Support specifying buffer direction
iio: buffer-dmaengine: Enable write support
Documentation/ABI/testing/sysfs-bus-iio-ad9739a | 17 +
.../devicetree/bindings/iio/dac/adi,ad9739a.yaml | 88 +++
.../devicetree/bindings/iio/dac/adi,axi-dac.yaml | 62 ++
MAINTAINERS | 17 +
drivers/iio/buffer/industrialio-buffer-dma.c | 100 +++-
drivers/iio/buffer/industrialio-buffer-dmaengine.c | 28 +-
drivers/iio/dac/Kconfig | 37 ++
drivers/iio/dac/Makefile | 2 +
drivers/iio/dac/ad9739a.c | 445 ++++++++++++++
drivers/iio/dac/adi-axi-dac.c | 644 +++++++++++++++++++++
drivers/iio/industrialio-backend.c | 144 +++++
drivers/iio/industrialio-buffer.c | 7 +
include/linux/iio/backend.h | 49 ++
include/linux/iio/buffer-dma.h | 4 +-
include/linux/iio/buffer-dmaengine.h | 6 +-
include/linux/iio/buffer.h | 3 +
16 files changed, 1624 insertions(+), 29 deletions(-)
---
base-commit: a276b4da56e988157a34b9fef9c46ebfd95f7f09
change-id: 20240326-iio-backend-axi-dac-497a707a5d88
--
Thanks!
- Nuno Sá
