On Thu, Mar 28, 2024 at 4:33 AM Folker Schwesinger <dev@xxxxxxxxxxxxxxxxxxxxx> wrote: > > Commit 8b5c2b45b8f0 disabled the internal pull-down for the strobe line > causing I/O errors in HS400 mode for various eMMC modules. > > Enable the internal strobe pull-down for ROCK Pi 4 boards. Also re-enable > HS400 mode, that was replaced with HS200 mode as a workaround for the > stability issues in: > cee572756aa2 ("arm64: dts: rockchip: Disable HS400 for eMMC on ROCK Pi 4"). > > This was tested on ROCK 4SE and ROCK Pi 4B+. > > Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts") > Signed-off-by: Folker Schwesinger <dev@xxxxxxxxxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi > index 281a12180703..b9d6284bb804 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi > @@ -194,6 +194,7 @@ &cpu_b1 { > }; > > &emmc_phy { > + rockchip,enable-strobe-pulldown; > status = "okay"; > }; > > @@ -648,7 +649,8 @@ &saradc { > &sdhci { > max-frequency = <150000000>; > bus-width = <8>; > - mmc-hs200-1_8v; Shouldn't this be kept around? The node should list all supported modes, not just the highest one. Same for the other patch. ChenYu > + mmc-hs400-1_8v; > + mmc-hs400-enhanced-strobe; > non-removable; > status = "okay"; > }; > -- > 2.44.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel