On Sat, Mar 23, 2024 at 08:15:17PM +0800, Peng Fan (OSS) wrote: > diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scmi/pinctrl.c > index 87d9b89cab13..0ecefe855432 100644 > --- a/drivers/firmware/arm_scmi/pinctrl.c > +++ b/drivers/firmware/arm_scmi/pinctrl.c > @@ -465,6 +465,7 @@ scmi_pinctrl_settings_conf(const struct scmi_protocol_handle *ph, > > tx = t->tx.buf; > tx->identifier = cpu_to_le32(selector); > + tx->function_id = cpu_to_le32(0xFFFFFFFF); > attributes = FIELD_PREP(GENMASK(1, 0), type) | > FIELD_PREP(GENMASK(9, 2), chunk); > tx->attributes = cpu_to_le32(attributes); This should have been done in patch 3. regards, dan carpenter > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index d45657aa986a..4e6f65cf0e76 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -450,6 +450,17 @@ config PINCTRL_ROCKCHIP
