On Wed, 2024-03-27 at 10:59 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 27/03/2024 10:34, Yu-chang Lee (李禹璋) wrote: > > On Wed, 2024-03-27 at 10:23 +0100, Krzysztof Kozlowski wrote: > >> > >> External email : Please do not click links or open attachments > until > >> you have verified the sender or the content. > >> On 27/03/2024 09:39, Krzysztof Kozlowski wrote: > >>> On 27/03/2024 06:57, yu-chang.lee wrote: > >>>> Add Smart Multimedia Interface Local Arbiter to mediatek > >>>> power domain. > >>>> > >>>> Signed-off-by: yu-chang.lee <yu-chang.lee@xxxxxxxxxxxx> > >>>> --- > >>>> .../devicetree/bindings/power/mediatek,power-controller.yaml | > 4 > >> ++++ > >>>> 1 file changed, 4 insertions(+) > >>>> > >>>> diff --git > >> a/Documentation/devicetree/bindings/power/mediatek,power- > >> controller.yaml > >> b/Documentation/devicetree/bindings/power/mediatek,power- > >> controller.yaml > >>>> index 8985e2df8a56..228c0dec5253 100644 > >>>> --- a/Documentation/devicetree/bindings/power/mediatek,power- > >> controller.yaml > >>>> +++ b/Documentation/devicetree/bindings/power/mediatek,power- > >> controller.yaml > >>>> @@ -125,6 +125,10 @@ $defs: > >>>> $ref: /schemas/types.yaml#/definitions/phandle > >>>> description: phandle to the device containing the SMI > >> register range. > >>>> > >>>> + mediatek,larb: > >>>> + $ref: /schemas/types.yaml#/definitions/phandle > >>>> + description: phandle to the device containing the LARB > >> register range. > >>> > >>> Why do you need it? > >>> > >>> Plus I also see mediatek,larbs and mediatek,larb-id... so now we > >> have > >>> third one similar. > >> > >> ... and not even tested! > >> > >> Best regards, > >> Krzysztof > >> > > Hi, > > > > I will double check the format of yaml for the next version, sorry > for > > inconvenience. But I did test it on mt8188 chromebook, the reason > why > > How do you test a binding on chromebook? > > > power domain need larb node is that when mtcmos power on, signal > glitch > > may produce. Power domain driver must reset larb when this happen > to > > prevent dummy transaction on bus. That why I need larb node in dts. > > No one talks here about larb node... Sorry, May you elaborate on what information I need to provide to you or it is just a syntax problem I need to fix? Thanks Best Regards, Yu-chang > > Best regards, > Krzysztof >
