On Mon, 25 Mar 2024 17:19:04 +0100, Dragan Simic wrote: > Following the approach used to enable the Mali GPU on the rk3588-evb1, [1] > do the same for the Pine64 QuartzPro64, which uses nearly identical hardware > design as the RK3588 EVB1. > > The slight disadvantage is that the regulator coupling logic requires the > regulators to be always on, which is also noted in the comments. This is > obviously something to be improved at some point in the future, but should > be fine for now, especially because the QuartzPro64 isn't a battery-powered > board, so low power consumption isn't paramount. > > [1] https://lore.kernel.org/linux-rockchip/20240325153850.189128-5-sebastian.reichel@xxxxxxxxxxxxx/ > > Signed-off-by: Dragan Simic <dsimic@xxxxxxxxxxx> > --- > .../arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3588-quartzpro64.dtb' for 0f3759ee390f245dac447bbee038445ddfecbec0.1711383286.git.dsimic@xxxxxxxxxxx: Error: arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts:288.1-5 Label or path gpu not found FATAL ERROR: Syntax error parsing input tree make[3]: *** [scripts/Makefile.lib:427: arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb] Error 1 make[2]: *** [scripts/Makefile.build:485: arch/arm64/boot/dts/rockchip] Error 2 make[2]: Target 'arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1387: rockchip/rk3588-quartzpro64.dtb] Error 2 make: *** [Makefile:240: __sub-make] Error 2 make: Target 'rockchip/rk3588-quartzpro64.dtb' not remade because of errors.
