On 26/03/2024 15:10, Jason A. Donenfeld wrote: > On Mon, Mar 25, 2024 at 10:51:25PM +0100, Krzysztof Kozlowski wrote: >>> .owner = THIS_MODULE, >> >> This is clearly some abandoned driver... sigh... I thought we get rid of >> all this owner crap. Many years ago. How could it appear back if >> automated tools report it? >> >> Considering how many failures LKP reported for your patchsets, I have >> real doubts that anyone actually tests this code. > > Now you're commenting on the context rather than the patch. > > No, this isn't an abandoned driver, no it's not untested. Rather, it's > code I maintain, care deeply about, and have a tree that receives quite > a bit of testing (random.git) where I'll be taking these OF patches in > the case that this patchset improves (and thanks very much for your I apologize. I jumped too fast to conclusions and missed important point - acpi drivers do need to set the owner. I am sorry. (platform driver do not need, but that's a different thing) Best regards, Krzysztof