On 26/03/2024 12:05, Kanak Shilledar wrote:
> From: Kanak Shilledar <kanakshilledar111@xxxxxxxxxxxxxx>
>
> Convert the Actions Semi Owl UART to newer DT schema.
> Created DT schema based on the .txt file which had
> `compatible`, `reg`, `clocks` and `interrupts` as the
That's not true. Old binding file did not have clocks. You did more than
conversion and I asked you to describe changes which are different than
pure conversion.
Instead of sending another version the same day, can you please read
carefully comments you receive?
> required properties. This binding is used by Actions S500, S700
> and S900 SoC. S700 and S900 use the same UART compatible string.
> Implemented a full node example for the UART, referenced S500 SoC
> devicetree include.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Drop, you made MANY MORE changes than I asked, up to the point of making
it broken.
I don't understand. I asked three things. One you ignored, two
implemented and then added more.
> Signed-off-by: Kanak Shilledar <kanakshilledar111@xxxxxxxxxxxxxx>
> ---
...
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
That's surprising. Nothing in the changelog explains this.
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/actions,s500-cmu.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + uart0: serial@b0126000 {
> + compatible = "actions,s500-uart", "actions,owl-uart";
> + reg = <0xb0126000 0x1000>;
> + clocks = <&cmu CLK_UART0>;
> + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
NAK.
Examples are not disabled.
Best regards,
Krzysztof
