On 25.03.2024 9:25 PM, Stanislav Jakubek wrote: > On Mon, Mar 25, 2024 at 08:28:27PM +0100, Konrad Dybcio wrote: >> On 24.03.2024 3:04 PM, Stanislav Jakubek wrote: >>> Add a device tree for the Motorola Moto G (2013) smartphone based >>> on the Qualcomm MSM8226 SoC. >>> >>> Initially supported features: >>> - Buttons (Volume Down/Up, Power) >>> - eMMC >>> - Hall Effect Sensor >>> - SimpleFB display >>> - TMP108 temperature sensor >>> - Vibrator >>> >>> Signed-off-by: Stanislav Jakubek <stano.jakubek@xxxxxxxxx> >>> --- >> >> [...] >> >>> + hob-ram@f500000 { >>> + reg = <0x0f500000 0x40000>, >>> + <0x0f540000 0x2000>; >>> + no-map; >>> + }; >> >> Any reason it's in two parts? Should it be one contiguous region, or >> two separate nodes? >> >> lgtm otherwise > > Hi Konrad, I copied this from downstream as-is. > According to the downstream docs [1]: > > HOB RAM MMAP Device provides ability for userspace to access the > hand over block memory to read out modem related parameters. > > And the two regs are the "DHOB partition" and "SHOB partition". Oh right, motorola made some inventions here.. > > I suppose this is something Motorola (firmware?) specific (since the > downstream compatible is mmi,hob_ram [2]). > Should I split this into 2 nodes - dhob@f500000 and shob@f540000? Yes please and add the downstream txt link to the commit message in case somebody was curious down the line. Konrad