On 26/03/2024 09:59, Varadarajan Narayanan wrote: >>> --- >>> .../dt-bindings/interconnect/qcom,ipq9574.h | 62 +++++++++++++++++++ >>> 1 file changed, 62 insertions(+) >>> create mode 100644 include/dt-bindings/interconnect/qcom,ipq9574.h >>> >>> diff --git a/include/dt-bindings/interconnect/qcom,ipq9574.h b/include/dt-bindings/interconnect/qcom,ipq9574.h >>> new file mode 100644 >>> index 000000000000..b7b32aa6bbb1 >>> --- /dev/null >>> +++ b/include/dt-bindings/interconnect/qcom,ipq9574.h >>> @@ -0,0 +1,62 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>> +#ifndef INTERCONNECT_QCOM_IPQ9574_H >>> +#define INTERCONNECT_QCOM_IPQ9574_H >>> + >>> +#define IPQ_APPS_ID 9574 /* some unique value */ >> >> Why random unique values are bindings? Why this cannot be 0? Please >> explain how this is used by DTS and driver. > > This 'id' is not used by the driver or DTS. It is a unique id that Then it is not a binding really. Don't put driver stuff to bindings. Best regards, Krzysztof
