On Mon, 25 Mar 2024 16:58:47 +0100
Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> wrote:
> Hi,
>
> On Mon, Mar 25, 2024 at 04:44:41PM +0100, Boris Brezillon wrote:
> > On Mon, 25 Mar 2024 16:37:20 +0100
> > Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> wrote:
> >
> > > From: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> > >
> > > Enable the Mali GPU in the Rock 5B.
> > >
> > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> >
> > I don't remember writing this patch ;-), maybe I screwed authorship at
> > some point, dunno.
>
> mh, I cherry-picked the DT patches from your branch before
> cleaning them up.
Yep, I probably wrote this patch and asked someone else to test. I
couldn't find any traces of this patch where I'm not flagged as the
author in any of my local branches.
>
> > > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> > > ---
> > > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > index 1fe8b2a0ed75..096ee7a98b89 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > @@ -180,6 +180,11 @@ &cpu_l3 {
> > > cpu-supply = <&vdd_cpu_lit_s0>;
> > > };
> > >
> > > +&gpu {
> > > + mali-supply = <&vdd_gpu_s0>;
> > > + status = "okay";
> > > +};
> > > +
> > > &i2c0 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&i2c0m2_xfer>;
> > > @@ -470,6 +475,7 @@ rk806_dvs3_null: dvs3-null-pins {
> > >
> > > regulators {
> > > vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 {
> > > + regulator-always-on;
> >
> > Hm, should we mention why the regulator is always on here?
>
> In case of the EVB1 it's needed because the generic coupler driver
> cannot handle regulators that are not always on.
Ah, okay. I thought I added that for a different reason.
> I'm not sure why
> it was added for the Rock 5B. I will check if it works without that
> flag.
