Hi, Krzysztof, On 3/25/24 09:11, Krzysztof Kozlowski wrote: > Complete the example of recommended order of properties by adding > missing address/size-cells. They are not necessary to illustrate the > style, but lack of them us bit really correct DTS code which might some typo here > confuse readers. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Cc: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/dts-coding-style.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst > index a9bdd2b59dca..8a68331075a0 100644 > --- a/Documentation/devicetree/bindings/dts-coding-style.rst > +++ b/Documentation/devicetree/bindings/dts-coding-style.rst > @@ -144,6 +144,8 @@ Example:: > #dma-cells = <1>; > clocks = <&clock_controller 0>, <&clock_controller 1>; > clock-names = "bus", "host"; > + #address-cells = <1>; > + #size-cells = <1>; I propose having #address-cells and #size-cells after ranges, because they are related: https://devicetree-specification.readthedocs.io/en/stable/devicetree-basics.html#ranges Looking good: Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> > vendor,custom-property = <2>; > status = "disabled"; >
