On Sunday, March 24th, 2024 at 16:15, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
>
> On 24/03/2024 07:28, Pratham Patel wrote:
>
> > The addition of `of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing`
>
>
> Please refer to commits using commit sha () syntax, as mentioned in
> submitting patches.
Noticed that in the wiki but didn't do that since the commit hash for the commit
was different in each branch (of the stable tree). Maybe I should have copied the SHA
from Linus' tree. I will do that.
> > + /*
> > + *analog-sound {
> > + * compatible = "audio-graph-card";
> > + * label = "rk3588-es8316";
>
>
> Do not comment out code. Instead disable the nodes and provide
> appropriate comment describing reason.
I tried changing the status from okay to disabled. That didn't work. The SBC
still locked up during boot.
> Anyway, this does not look like correct solution. DTS is independent of
> OS, so bug in fwlink does not matter for DTS. Either DTS is a correct
> hardware representation or not.
I agree, it's not the correct solution. It is a temporary workaround for the regression
caused. I will send more patches once I receive a few more RK3588-based SBCs and investigate.
-- Pratham Patel
