Am 22.03.24 um 16:49 schrieb Andrew Lunn: >> I (currently) can't put in the led node e.g. >> linux,default-trigger = "link100|link1000|tx|rx"; >> Right? > No. The trigger will be 'netdev'. Or 'heartbeat', or > 'kbd-numlock'. OK. > They are just LEDs, they can be used for > anything. While testing some of this code i had the keyboard numlock > indicating network packets, since it easier to see than the RJ45 > socket... The same applies the other way. The RJ45 LEDs are just Linux > LEDs, they can be used for anything... > > I do have some code adding additional properties for the blink > reason. However, it is very debatable if it belongs in DT. DT > describes hardware, not configuration of hardware. > > Do you actually have labels on the case indicating what the LEDs mean? > It could be we describe the label, which is hardware, not the > configuration of the LED, which is policy from user space. I have seen it on customer products, and I have seen it in manuals, and it can help in customer support. Personally I would want it for consistency reasons, so that even if hardware engineers confused 0 and 1 I can ensure consistent behaviour out of the box. It could be the vendor recommended or intended configuration ...
