On 3/21/24 17:41, Wadim Mueller wrote: > +++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi > @@ -0,0 +1,237 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later Please use the dual license model (GPL-2.0+ OR BSD-3-Clause) for device tree files, as the TF-A version of these files [0] already uses this license. Using a consistent license is needed to keep files in sync between upstream versions of Linux and TF-A for S32G in the future. > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. This paragraph is already implied by the SPDX tag. > + * > + */> + > +#include <dt-bindings/interrupt-controller/arm-gic.h> > +/ { Missing empty line here between header include and '{'? [0] https://github.com/nxp-auto-linux/arm-trusted-firmware/blob/release/bsp39.0-2.5/fdts/s32g3.dtsi#L1 Regards, Ghennadi