On Fri, Mar 22, 2024 at 04:15:23PM +0200, Abel Vesa wrote: > On 24-03-22 15:38:03, Dmitry Baryshkov wrote: > > On Fri, 22 Mar 2024 at 15:36, Abel Vesa <abel.vesa@xxxxxxxxxx> wrote: > > > On 24-03-22 15:30:54, Dmitry Baryshkov wrote: > > > > On Fri, 22 Mar 2024 at 15:22, Abel Vesa <abel.vesa@xxxxxxxxxx> wrote: > > > > > +static int dp_display_get_connector_type(struct platform_device *pdev, > > > > > + const struct msm_dp_desc *desc) > > > > > +{ > > > > > + struct device *dev = &pdev->dev; > > > > > + struct device_node *aux_bus; > > > > > + struct device_node *panel; > > > > > + int ret = DRM_MODE_CONNECTOR_DisplayPort; > > > > > + > > > > > + /* legacy platforms specify connector type in match data */ > > > > > + if (desc->connector_type == DRM_MODE_CONNECTOR_eDP || > > > > > + desc->connector_type == DRM_MODE_CONNECTOR_DisplayPort) > > > > > > > > misaligned > > > > > > > > > > Sure, will fix. > > > > > > > > + return desc->connector_type; > > > > > > > > Can we drop this part completely? > > > > > > > > > > You mean the whole if clause? How should we handle the legacy approach > > > then? > > > > Legacy platforms still have the aux-bus/panel. so they should be > > handled by the check below. > > > > Oh, in that case we can drop the connector_type from every desc for all > platforms. Guys, please trim your replies! Johan