Mark Brown, 2024-03-21T16:58:44+00:00: > On Thu, Mar 21, 2024 at 05:55:17PM +0100, Karel Balej wrote: > > Lee Jones, 2024-03-21T16:20:45+00:00: > > > On Thu, 21 Mar 2024, Karel Balej wrote: > > > > > > > +static const struct regmap_config pm886_i2c_regmap = { > > > > > > + .reg_bits = 8, > > > > > > + .val_bits = 8, > > > > > > + .max_register = PM886_REGMAP_CONF_MAX_REG, > > > > > > +}; > > > > > > Why is this in here? > > > > > Because since I moved the regulators regmap initialization into the > > > > regulators driver, I need to access it from there. > > > > So move it into the regulators driver? > > > It is used in the MFD driver too for the base regmap. > > You shouldn't be creating two regmaps for the same set of registers, > that just opens the potential for confusion. Just the regmap config is the same. Otherwise, each regmap lives at a different I2C address. Regards, K. B.