On 20/03/2024 18:37, Emmanuel Gil Peyrot wrote: > The documentation got added in f8aa519976b38e67aae02d2db3e2998513305e80, Please use commit SHA () syntax (see submitting patches). > but it hasn’t been added to the driver so it was unused. Eh? That's not how this works. > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@xxxxxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 2 +- That's DTS, not bindings. > drivers/iommu/rockchip-iommu.c | 3 +++ Driver code cannot be combined with DTS in one patch. > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > index 87b83c87bd55..2a23b4dc36e4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > @@ -704,7 +704,7 @@ vp3: port@3 { > }; > > vop_mmu: iommu@fdd97e00 { > - compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu"; > + compatible = "rockchip,rk3588-iommu"; NAK. Best regards, Krzysztof