On 3/6/2024 2:01 PM, Krzysztof Kozlowski wrote: > On 06/03/2024 08:30, Odelu Kukatla wrote: >> It adds QoS support for QNOC device and includes support for >> configuring priority, priority forward disable, urgency forwarding. >> This helps in priortizing the traffic originating from different >> interconnect masters at NoC(Network On Chip). >> >> Signed-off-by: Odelu Kukatla <quic_okukatla@xxxxxxxxxxx> >> --- >> drivers/interconnect/qcom/icc-rpmh.c | 105 +++++++++++++++++++++++++++ >> drivers/interconnect/qcom/icc-rpmh.h | 32 ++++++++ >> 2 files changed, 137 insertions(+) > >> >> + if (desc->config) { >> + struct resource *res; >> + void __iomem *base; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + if (!res) { >> + dev_warn(dev, "Skipping QoS, failed to get resource\n"); > > Why is this a warning? If the MMIO is not required, your driver should > not spawn warnings. > Right, it should not be a warning, will clean it up. > >> + goto skip_qos_config; >> + } >> + >> + base = devm_ioremap(dev, res->start, resource_size(res)); > > Combine these two (there's a helper for that). > I will address this in v4. >> + if (IS_ERR(base)) { >> + dev_warn(dev, "Skipping QoS, ioremap failed: %ld\n", PTR_ERR(base)); >> + goto skip_qos_config; >> + }; >> + >> + qp->regmap = devm_regmap_init_mmio(dev, base, desc->config); >> + > > Drop blank line. > >> + if (IS_ERR(qp->regmap)) { >> + dev_warn(dev, "Skipping QoS, regmap failed; %ld\n", PTR_ERR(qp->regmap)); >> + goto skip_qos_config; >> + } >> + >> + qp->num_clks = devm_clk_bulk_get_all(qp->dev, &qp->clks); >> + if (qp->num_clks < 0) { >> + dev_warn(dev, "Skipping QoS, failed to get clk: %d\n", qp->num_clks); > > dev_info(), because current binding sais clocks are not required and you > are not allowed to affect ABI. While ABI here does not look broken, > spawning new warnings to proper users is not welcomed. > I will convert it to dev_info() in next version. But qp->num_clks = 0 if clock property is not added, so it does not spawn warning. will move all other dev_warn() to dev_info(). > Best regards, > Krzysztof > Thanks, Odelu