Hi Sudan, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.8 next-20240320] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sudan-Landge/virt-vmgenid-rearrange-code-to-make-review-easier/20240319-223642 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20240319143253.22317-5-sudanl%40amazon.com patch subject: [PATCH v1 4/4] virt: vmgenid: add support for devicetree bindings config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240321/202403210035.LODSw2s6-lkp@xxxxxxxxx/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 8f68022f8e6e54d1aeae4ed301f5a015963089b7) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240321/202403210035.LODSw2s6-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202403210035.LODSw2s6-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from drivers/virt/vmgenid.c:16: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 547 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from drivers/virt/vmgenid.c:16: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from drivers/virt/vmgenid.c:16: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 584 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ >> drivers/virt/vmgenid.c:79:38: error: incomplete definition of type 'struct acpi_device' 79 | status = acpi_evaluate_object(device->handle, "ADDR", NULL, &parsed); | ~~~~~~^ include/linux/acpi.h:795:8: note: forward declaration of 'struct acpi_device' 795 | struct acpi_device; | ^ drivers/virt/vmgenid.c:96:28: error: incomplete definition of type 'struct acpi_device' 96 | devm_memremap(&device->dev, phys_addr, VMGENID_SIZE, MEMREMAP_WB) | ~~~~~~^ include/linux/acpi.h:795:8: note: forward declaration of 'struct acpi_device' 795 | struct acpi_device; | ^ drivers/virt/vmgenid.c:102:45: error: incomplete definition of type 'struct acpi_device' 102 | status = acpi_install_notify_handler(device->handle, ACPI_DEVICE_NOTIFY, | ~~~~~~^ include/linux/acpi.h:795:8: note: forward declaration of 'struct acpi_device' 795 | struct acpi_device; | ^ 6 warnings and 3 errors generated. vim +79 drivers/virt/vmgenid.c 657fab4d1001e1 Sudan Landge 2024-03-19 69 657fab4d1001e1 Sudan Landge 2024-03-19 70 static int vmgenid_add_acpi(struct device *dev, struct vmgenid_state *state) 657fab4d1001e1 Sudan Landge 2024-03-19 71 { 657fab4d1001e1 Sudan Landge 2024-03-19 72 struct acpi_device *device = ACPI_COMPANION(dev); af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 73 struct acpi_buffer parsed = { ACPI_ALLOCATE_BUFFER }; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 74 union acpi_object *obj; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 75 phys_addr_t phys_addr; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 76 acpi_status status; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 77 int ret = 0; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 78 af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 @79 status = acpi_evaluate_object(device->handle, "ADDR", NULL, &parsed); af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 80 if (ACPI_FAILURE(status)) { af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 81 ACPI_EXCEPTION((AE_INFO, status, "Evaluating ADDR")); af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 82 return -ENODEV; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 83 } af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 84 obj = parsed.pointer; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 85 if (!obj || obj->type != ACPI_TYPE_PACKAGE || obj->package.count != 2 || af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 86 obj->package.elements[0].type != ACPI_TYPE_INTEGER || af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 87 obj->package.elements[1].type != ACPI_TYPE_INTEGER) { af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 88 ret = -EINVAL; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 89 goto out; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 90 } af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 91 af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 92 phys_addr = (obj->package.elements[0].integer.value << 0) | af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 93 (obj->package.elements[1].integer.value << 32); 657fab4d1001e1 Sudan Landge 2024-03-19 94 657fab4d1001e1 Sudan Landge 2024-03-19 95 ret = setup_vmgenid_state(state, 657fab4d1001e1 Sudan Landge 2024-03-19 96 devm_memremap(&device->dev, phys_addr, VMGENID_SIZE, MEMREMAP_WB) 657fab4d1001e1 Sudan Landge 2024-03-19 97 ); 657fab4d1001e1 Sudan Landge 2024-03-19 98 if (ret) 657fab4d1001e1 Sudan Landge 2024-03-19 99 goto out; 657fab4d1001e1 Sudan Landge 2024-03-19 100 657fab4d1001e1 Sudan Landge 2024-03-19 101 dev->driver_data = state; 657fab4d1001e1 Sudan Landge 2024-03-19 102 status = acpi_install_notify_handler(device->handle, ACPI_DEVICE_NOTIFY, 657fab4d1001e1 Sudan Landge 2024-03-19 103 vmgenid_acpi_handler, dev); 657fab4d1001e1 Sudan Landge 2024-03-19 104 if (ACPI_FAILURE(status)) { 657fab4d1001e1 Sudan Landge 2024-03-19 105 dev_err(dev, "Failed to install acpi notify handler"); 657fab4d1001e1 Sudan Landge 2024-03-19 106 ret = -ENODEV; 657fab4d1001e1 Sudan Landge 2024-03-19 107 dev->driver_data = NULL; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 108 goto out; af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 109 } 657fab4d1001e1 Sudan Landge 2024-03-19 110 out: 657fab4d1001e1 Sudan Landge 2024-03-19 111 ACPI_FREE(parsed.pointer); 657fab4d1001e1 Sudan Landge 2024-03-19 112 return ret; 657fab4d1001e1 Sudan Landge 2024-03-19 113 } af6b54e2b5baa5 Jason A. Donenfeld 2022-02-23 114 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
