On 20/03/2024 10:44, Xianwei Zhao via B4 Relay wrote: > From: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx> > > Amlogic A4 is an application processor designed for smart audio > and IoT applications. > > Add basic support for the A4 based Amlogic BA400 board, which describes > the following components: CPU, GIC, IRQ, Timer and UART. > These are capable of booting up into the serial console. > > Signed-off-by: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts | 42 ++++++++++++++ > arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi | 66 ++++++++++++++++++++++ > arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 40 +++++++++++++ > 4 files changed, 149 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 1ab160bf928a..9a50ec11bb8d 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > +dtb-$(CONFIG_ARCH_MESON) += amlogic-a4-a113l2-ba400.dtb > dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb > dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb > dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts b/arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts > new file mode 100644 > index 000000000000..43a9c666e1de > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts > @@ -0,0 +1,42 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2024 Amlogic, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "amlogic-a4.dtsi" > + > +/ { > + model = "Amlogic A113L2 ba400 Development Board"; > + compatible = "amlogic,ba400","amlogic,a4"; Still missing space. You received comment about this. Fix entire file, not just one occurrence. Best regards, Krzysztof