Hi Rob,
It's been a few weeks.
Gentle ping :)
Regards,
Raphaël
Le 06/03/2024 à 08:53, Raphaël Gallais-Pou a écrit :
Le 04/03/2024 à 19:40, Rob Herring a écrit :
On Fri, Mar 01, 2024 at 06:47:28PM +0100, Raphael Gallais-Pou wrote:
'st,passive_colling_temp' does not appear in the device-tree, and 'reg'
is missing in the device description.
Convert st,stih407-thermal binding to DT schema format in order to clean
unused 'st,passive_cooling_temp' and add missing 'reg' property.
Signed-off-by: Raphael Gallais-Pou <rgallaispou@xxxxxxxxx>
Hi Rob,
...
+ interrupts:
+ description:
+ For thermal sensors for which no interrupt has been defined, a
polling
+ delay of 1000ms will be used to read the temperature from device.
maxItems: 1
Ack.
+
+ '#thermal-sensor-cells': true
const: 1
Also, not in the original binding, so please state in the commit msg
why you are adding it.
I have mixed feeling regarding the value. Wouldn't this better be
'const: 0' ?
In the thermal-sensor binding it is specified that it should be 0 for
single sensor nodes, which is our case.
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ temperature-sensor@91a0000 {
+ compatible = "st,stih407-thermal";
+ reg = <0x91a0000 0x28>;
+ clock-names = "thermal";
+ clocks = <&CLK_SYSIN>;
+ interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
+ #thermal-sensor-cells = <0>;
If I misunderstand something and the value must be 1 then I will also
change the value here and in the dt patches of the serie.
Regards,
Raphaël
+ };
+...
