Re: [PATCH v2 01/13] thermal/drivers/mediatek/lvts_thermal: retrieve all calibration bytes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 18/03/24 22:22, Nicolas Pitre ha scritto:
From: Nicolas Pitre <npitre@xxxxxxxxxxxx>

Calibration values are 24-bit wide. Those values so far appear to span
only 16 bits but let's not push our luck.


I wonder how much feedback you got on v1 - I didn't even look and will not lose
time with that - but regardless, if you don't add the right people to the Cc field,
I really don't think that you'll ever get your patches reviewed (and probably also
not accepted).

That -- especially if you don't even Cc all the relevant maintainers...!

Please read:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

P.S.:
scripts/get_maintainer.pl lvts-8186-8188-patches.patch

"Rafael J. Wysocki" <rafael@xxxxxxxxxx> (supporter:THERMAL)
Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> (supporter:THERMAL,commit_signer:21/22=95%)
Zhang Rui <rui.zhang@xxxxxxxxx> (reviewer:THERMAL)
Lukasz Luba <lukasz.luba@xxxxxxx> (reviewer:THERMAL)
Rob Herring <robh@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Conor Dooley <conor+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Matthias Brugger <matthias.bgg@xxxxxxxxx> (maintainer:ARM/Mediatek SoC support,commit_signer:4/22=18%) AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> (maintainer:ARM/Mediatek SoC support,commit_signer:13/22=59%)
Alexandre Mergnat <amergnat@xxxxxxxxxxxx> (commit_signer:11/22=50%)
"Nícolas F. R. A. Prado" <nfraprado@xxxxxxxxxxxxx> (commit_signer:10/22=45%,authored:7/22=32%,added_lines:128/453=28%,removed_lines:45/98=46%) Balsam CHIHI <bchihi@xxxxxxxxxxxx> (authored:4/22=18%,added_lines:235/453=52%,removed_lines:22/98=22%,in file)
Chen-Yu Tsai <wenst@xxxxxxxxxxxx> (authored:2/22=9%)
Minjie Du <duminjie@xxxxxxxx> (authored:2/22=9%)
Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> (authored:2/22=9%,added_lines:72/453=16%,removed_lines:17/98=17%)
linux-pm@xxxxxxxxxxxxxxx (open list:THERMAL)
devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@xxxxxxxxxxxxxxx (open list)
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated list:ARM/Mediatek SoC support)
linux-mediatek@xxxxxxxxxxxxxxxxxxx (moderated list:ARM/Mediatek SoC support)


Found while looking at the original Mediatek driver code.

Signed-off-by: Nicolas Pitre <npitre@xxxxxxxxxxxx>
---
  drivers/thermal/mediatek/lvts_thermal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index 98d9c80bd4..8aa6a8675b 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -679,7 +679,7 @@ static int lvts_calibration_init(struct device *dev, struct lvts_ctrl *lvts_ctrl
for (i = 0; i < lvts_ctrl_data->num_lvts_sensor; i++)
  		memcpy(&lvts_ctrl->calibration[i],
-		       efuse_calibration + lvts_ctrl_data->cal_offset[i], 2);
+		       efuse_calibration + lvts_ctrl_data->cal_offset[i], 3);
return 0;
  }





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux