On 3/19/24 06:49, Krzysztof Kozlowski wrote:
On 18/03/2024 21:12, Javier Carrasco wrote:
Convert adc128d818 bindings to dtschema to support validation.
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Thank you for your patch. There is something to discuss/improve.
+$id: http://devicetree.org/schemas/hwmon/ti,adc128d818.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments ADC128D818 ADC System Monitor With Temperature Sensor
+
+maintainers:
+ - Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
+
+description: |
+ The ADC128D818 is a 12-Bit, 8-Channel Analog to Digital Converter (ADC)
+ with a temperature sensor and an I2C interface.
+
+ Datasheets:
+ https://www.ti.com/product/ADC128D818
+
+properties:
+ compatible:
+ const: ti,adc128d818
+
+ reg:
+ maxItems: 1
+
+ ti,mode:
You need | to preserve the formatting.
Thanks, I overlooked that. If I am not mistaken, 2 are still missing
(ti,mode and vref-supply descriptions).
By the way, do you know why dtschema does not complain about that? If I
place a '|' in a wrong place, it does complain, though.
With this:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof
Best regards,
Javier Carrasco
