On Mon, Mar 18, 2024 at 2:54 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Mon, Mar 18, 2024 at 11:43:45AM +0000, Lucas Tanure wrote: > > Add the T7 PLL clock controller driver in the T7 SoC family. > > > > This is RFC patch that enables SDCard, Ethernet and Clocking > > for Amlogic T7 soc. > > In this current state the patch doesn't work and gives a kernel > > panic when probing the meson-axg-mmc for the SDCard. > > DO NOT MERGE. > > > > Signed-off-by: Lucas Tanure <tanure@xxxxxxxxx> > > --- > > drivers/clk/meson/Kconfig | 25 + > > drivers/clk/meson/Makefile | 2 + > > drivers/clk/meson/t7-peripherals.c | 6368 +++++++++++++++++ > > drivers/clk/meson/t7-peripherals.h | 131 + > > drivers/clk/meson/t7-pll.c | 1543 ++++ > > drivers/clk/meson/t7-pll.h | 83 + > > .../clock/amlogic,t7-peripherals-clkc.h | 410 ++ > > .../dt-bindings/clock/amlogic,t7-pll-clkc.h | 69 + > > 8 files changed, 8631 insertions(+) > > create mode 100644 drivers/clk/meson/t7-peripherals.c > > create mode 100644 drivers/clk/meson/t7-peripherals.h > > create mode 100644 drivers/clk/meson/t7-pll.c > > create mode 100644 drivers/clk/meson/t7-pll.h > > > create mode 100644 include/dt-bindings/clock/amlogic,t7-peripherals-clkc.h > > create mode 100644 include/dt-bindings/clock/amlogic,t7-pll-clkc.h > > I'm assuming since this is an RFC you know these go in a separate patch > with the DT binding schema which is missing. > > Rob Yes, This would be a few patches at least. The thing right now is to get it to work. I think some obscure thing is missing when setting up these clocks, and only Amlogic knows. After I have a working driver, I will submit a proper patch series with documentation for the drivers and device trees. Thanks Lucas Tanure