On 17/03/2024 19:26, Jan Petrous (OSS) wrote: >> Add support for NXP S32 SoC family's GMAC to the stmmac network driver. >> This driver implementation is based on the patchset originally contributed by >> Chester Lin [1], which itself draws heavily from NXP's downstream >> implementation [2]. The patchset was never merged. >> > > Hi Wadim, > > Thank you for your upstreaming activities, but I would like to note that > the old NXP S32CC stmmac glue was rewritten lately and will be part of next > NXP BSP Linux release planned for April. > > The rework was done mainly to allow simpler upstreaming process, so I would recommend > to postpone your current work. I suggest you working with upstream first instead of claiming that upstream contributions should align with your downstream work. To be clear: your downstream NXP BSP does not matter. If you think this submission needs any particular changes, then please comment on specifics, but such broad statement that community should wait till NXP will be so kind to allow upstream work is just not acceptable. Best regards, Krzysztof
