Hi Geert, Thank you for the review. On Fri, Mar 15, 2024 at 12:59 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Fri, Mar 15, 2024 at 11:31 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Introduce helper functions for performing I2C read and write operations > > in the RIIC driver. > > > > These helper functions lay the groundwork for adding support for the > > RZ/V2H SoC. This is essential because the register offsets for the RZ/V2H > > SoC differ from those of the RZ/A SoC. By abstracting the read and write > > operations, we can seamlessly adapt the driver to support different SoC > > variants without extensive modifications. > > > > This patch is part of the preparation process for integrating support for > > the RZ/V2H SoC into the RIIC driver. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > v1->v2 > > - Renamed i2c read/write to riic_readb/riic_writeb > > - Made riic as first parameter for riic_writeb > > Thanks for the update! > > > --- a/drivers/i2c/busses/i2c-riic.c > > +++ b/drivers/i2c/busses/i2c-riic.c > > @@ -105,9 +105,19 @@ struct riic_irq_desc { > > char *name; > > }; > > > > +static inline void riic_writeb(struct riic_dev *riic, u8 offset, u8 val) > > Please use the same parameter order as writeb(), i.e. "val" before > "offset"), to increase uniformity. This also would make it easier > to review your changes using "git {diff,show} --color-words". > Agreed, I will update it in the next version. Cheers, Prabhakar