On 15/03/2024 00:49, Konrad Dybcio wrote: > > > On 3/15/24 00:20, Sebastian Raase wrote: >> Add pinctrl configuration for gpio-keys. Without this, >> camera button half-presses are not detected. >> >> Tested on discovery and pioneer. >> >> Fixes: e781633b6067 ("arm64: dts: qcom: Add support for Sony Xperia XA2/Plus/Ultra (Nile platform)") >> Signed-off-by: Sebastian Raase <linux@xxxxxxx> >> --- >> arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi >> index 87d0293c728d..823c21d5ee59 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi >> @@ -90,6 +90,8 @@ cam_vana_rear_vreg: cam-vana-rear-regulator { >> >> gpio-keys { >> compatible = "gpio-keys"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&gpio_keys_default>; > > It's fine to keep the "non-preferred" order, I'll probably send some > changes to nile and fix up the style while at it in the near future. Sebastian, Although it is also preferred to implement feedback the reviewer is asking. I don't understand why you insisted to keep the other order. Best regards, Krzysztof