On 14/03/2024 21:04, Anjelique Melendez wrote: > From: David Collins <quic_collinsd@xxxxxxxxxxx> > > Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation > to inclde compatible strings for PMXR2230 and PM6450 PMICs. Typo, include Two commits and quite different subjects... Please make it somehow consistent. Prefix is qcom,pmic-gpio, not qcom-pmic-gpio. Start either with capital or lower case - just choose one pattern. A nit, subject: drop second/last, redundant "binding". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof