On 14/03/2024 21:00, Sebastian Raase wrote: > Add pinctrl configuration for gpio-keys. Without this, > camera button half-presses are not detected. > > Tested on discovery and pioneer. > > Fixes: e781633b6067 ("arm64: dts: qcom: Add support for Sony Xperia XA2/Plus/Ultra (Nile platform)") > Signed-off-by: Sebastian Raase <linux@xxxxxxx> > --- > arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi > index 87d0293c728d..5eedca6f288f 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi > @@ -90,6 +90,8 @@ cam_vana_rear_vreg: cam-vana-rear-regulator { > > gpio-keys { > compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys_default>; A nit: Please reverse the order: pinctrl-0 then names > > key-camera-focus { > label = "Camera Focus"; > @@ -635,6 +637,13 @@ ts_lcd_id_active: ts-lcd-id-active-state { > bias-disable; > }; > > + gpio_keys_default: gpio-keys-default { Looks missing suffix (state) and test, so: It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof