On 14/03/2024 10:36, Sumit Garg wrote: >> >> But it then broke dtbs_check. > > See following breakage afterwards: > > $ make qcom/apq8016-schneider-hmibsc.dtb dtbs_check > <snip> > /home/sumit/build/upstream/linux/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: > leds: led@5: Unevaluated properties are not allowed ('reg' was > unexpected) > from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml# > /home/sumit/build/upstream/linux/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: > leds: led@6: Unevaluated properties are not allowed ('reg' was > unexpected) > from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml# > /home/sumit/build/upstream/linux/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: > leds: '#address-cells', '#size-cells' do not match any of the regexes: > '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' That's obvious, I don't get what is the question. Adding not correct properties is not a solution and dtbs_check correctly tells you that. If you only opened absolutely any existing upstream source, you would see how the gpio leds are represented in DTS. Best regards, Krzysztof