On Thu, Mar 14, 2024 at 1:35 AM Andre Przywara <andre.przywara@xxxxxxx> wrote: > > On Mon, 11 Mar 2024 17:20:50 -0500 > Samuel Holland <samuel@xxxxxxxxxxxx> wrote: > > Hi Samuel, > > thanks for having a look! > > > On 3/9/24 19:02, Andre Przywara wrote: > > > The X-Powers AXP717 is a PMIC used on some newer Allwinner devices. > > > Among quite some regulators it features the usual ADC/IRQ/power key > > > parts, plus a battery charger circuit, and some newly introduced USB > > > type-C circuitry. > > > > Do you plan to put the Type-C logic under a subnode, or should the > > Type-C connector node go directly under the PMIC node? Either way, the > > binding probably needs to be updated for that. > > I haven't looked into this yet, so cannot say which way to go. I > definitely consider this some non-trivial task, so indeed wanted to push > this off to later. > For now there is a device (Anbernic RG35XX) with that PMIC, so we need at > least the regulators to unblock this. USB support is not critical for now. > > > > Like two other recent PMICs, it lacks the DC/DC converter PWM frequency > > > control register, that rate is fixed here as well. > > > > > > Add the new compatible string, and add that to the list of PMICs without > > > the PWM frequency property. > > > > > > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> > > > --- > > > Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > > > index 06f1779835a1e..b8e8db0d58e9c 100644 > > > --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > > > +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > > > @@ -83,6 +83,7 @@ allOf: > > > enum: > > > - x-powers,axp313a > > > - x-powers,axp15060 > > > + - x-powers,axp717 > > > > > > then: > > > properties: > > > @@ -99,6 +100,7 @@ properties: > > > - x-powers,axp221 > > > - x-powers,axp223 > > > - x-powers,axp313a > > > + - x-powers,axp717 > > > - x-powers,axp803 > > > - x-powers,axp806 > > > - x-powers,axp809 > > > > The regulators patternProperties needs to be updated for the new boost > > regulator. > > Ah, I indeed missed this one. I think the former PMICs had this > batter->VBUS boost regulator hidden, controlled entirely by the PMIC? > I will need to check if exposing this will present any surprises. I > guess this goes together with the USB-C support, to have role switching, > unless this appears on some device with just USB-A or micro-B. > I will check what it takes to add this one, the regulator itself looks > easy. I don't think there was such a boost regulator on previous PMICs. It was just a passthrough, which is why on some boards such as the Cubietruck there is an external boost converter to put out 5V when just the battery is used. ChenYu
