On 3/13/24 13:30, Sumit Garg wrote:
Add Schneider Electric HMIBSC board DTS. The HMIBSC board is an IIoT Edge Box Core board based on the Qualcomm APQ8016E SoC. Support for Schneider Electric HMIBSC. Features: - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) - 1GiB RAM - 8GiB eMMC, SD slot - WiFi and Bluetooth - 2x Host, 1x Device USB port - HDMI - Discrete TPM2 chip over SPI - USB ethernet adaptors (soldered) Co-developed-by: Jagdish Gediya <jagdish.gediya@xxxxxxxxxx> Signed-off-by: Jagdish Gediya <jagdish.gediya@xxxxxxxxxx> Signed-off-by: Sumit Garg <sumit.garg@xxxxxxxxxx> ---
[...]
+ memory@80000000 { + reg = <0 0x80000000 0 0x40000000>; + };
I'm not sure the entirety of DRAM is accessible.. This override should be unnecessary, as bootloaders generally update the size field anyway.
+ + reserved-memory { + ramoops@bff00000 { + compatible = "ramoops"; + reg = <0x0 0xbff00000 0x0 0x100000>; + + record-size = <0x20000>; + console-size = <0x20000>; + ftrace-size = <0x20000>;
No ecc?
+ }; + }; + + usb2513 {
Please use a generic node name, like usb-hub and keep the nodes sorted.
+ compatible = "smsc,usb3503"; + reset-gpios = <&pm8916_gpios 1 GPIO_ACTIVE_LOW>; + initial-mode = <1>; + }; + + usb_id: usb-id { + compatible = "linux,extcon-usb-gpio"; + id-gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&usb_id_default>;
property-n property-names [...]
+ led@5 { + reg = <5>; + label = "apq8016-hmibsc:green:wlan";
These names look overly complicated.. s/apq8016-hmibsc://g?
+ +&blsp_i2c3 { + status = "okay"; + + eeprom@50 { + compatible = "atmel,24c32"; + reg = <0x50>; + }; +}; + +&blsp_i2c4 { + status = "okay"; + + adv_bridge: bridge@39 { + status = "okay";
???
+ + compatible = "adi,adv7533"; + reg = <0x39>; + + interrupt-parent = <&tlmm>; + interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
interrupts-extended Konrad