Hi Krzysztof, On Sat, Mar 9, 2024 at 2:30 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 09/03/2024 13:32, Biju Das wrote: > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>>> This looks like ABI break and commit msg is quite vague about it. > >>> > >>> OK, Will update the commit message as driver is taking care of the > >>> backward compatibility. > >> > >> Ah, I was not precise here, you should consider the impact this is on DTB used on other kernels. You > >> guys should really stop using imprecise/incorrect generic fallbacks and, since it is usually tricky to > >> know which fallback is correct or not, you should stop using them at all. > > > > There will be driver change to handle SoC specific compatible. > > > > So , > > > > old DTB + old kernel will have 16 pipe buffers > > old DTB + newer kernel will have 9 pipe buffers. > > New DTB + new kernel will have 9 pipe buffer. > > You missed new DTB and old kernel. This breaks all users of DTS. That's > the entire point of your broken generic compatibles which you did not > address. Doesn't DT guarantee only forward compatibility? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds