On 11/03/2024 04:18, Animesh Agarwal wrote: > On Mon, Mar 11, 2024 at 1:55 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> What changelog? Read carefully what I asked you few versions ago: > Below the sign off I have added changes done in all the versions > before and explained why imx51-pata was added. > >> "Please explain the differences done during conversion in the commit >> msg. There was no imx51 compatible in the binding before." > > "" > Changes in v4: > - added fsl,imx31-pata in compatible property as enum > - imx31-pata was not listed in compatible in original txt binding > - adding imx31-pata in enum ensures the node compiles to imx31.dtsi > Changes in v3: > - added fsl,imx51-pata in compatible property as enum > - imx51-pata was not listed in compatible in original txt binding > - adding imx51-pata in enum ensures the node compiles to imx51.dtsi > - fsl,imx27-pata is added as a const to ensure it is present always > "" > Aren't these lines enough for the said explanation? This is changelog, not commit msg. I did not ask to explain differences from pure conversion in changelog. Best regards, Krzysztof