On 10/03/2024 14:36, Animesh Agarwal wrote: > On 10/03/2024 at 18:37 Krzysztof Kozlowski wrote: >> Please respond inline, instead of top-posting, because it makes your >> emails hard to follow. >> > https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340 > <https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340> > > Already taken a note of it, will follow inline here onwards. > >>> On Sat, Mar 9, 2024 at 11:38 PM Krzysztof Kozlowski < >>> krzysztof.kozlowski@xxxxxxxxxx> wrote: >>> >>>> On 09/03/2024 17:07, Animesh Agarwal wrote: >>>>> Convert the imx-pata bindings to DT schema. >>>>> >>>>> Signed-off-by: Animesh Agarwal <animeshagarwal28@xxxxxxxxx> >>>>> --- >>>>> Changes in v3: >>>>> - added fsl,imx51-pata in compatible property >>>> >>>> Please explain the differences done during conversion in the commit msg. >> How did you solve this? > > Added proper explanation for fsl,imx51-pata addition in the compatible > property in commit message of v4. I don't see anything about this in commit msg. Commit msg is exactly the same as before. Try yourself - use b4 shazam to apply your patch and see if commit msg contains that information. > >>>> This allows only imx51 and disallows imx27 alone, which is not what old >> ------------------------------^^^^^^^^^^^^^^^^^^^^^ >> How did you solve this? > > I will resubmit patch v4 with more explanation. You mean v5? You need oneOf allowing usage of imx27 alone. Best regards, Krzysztof
