Hi Sergey, Thanks for your review. On 2024-03-09 22:28:47 +0300, Sergey Shtylyov wrote: > On 3/9/24 6:53 PM, Niklas Söderlund wrote: > > > The driver used the OF node of the device itself when registering the > > s/OF/DT/, perhaps? I thought we referred to it as DT node when talking about .dts{i,o} files and OF node when it was used inside the kernel? The infrastructure around its called of_get_child_by_name() and of_node_put() for example. And I believe OF is an abbreviation for Open Firmware (?). IIRC this is because ACPI might also be in the mix somewhere and DT != ACPI :-) I'm happy to change this if I understood it wrong, if not I like to keep it as is. > > > MDIO bus. While this works it creates a problem, it forces any MDIO bus > > While this works, it creates a problem: it forces any MDIO bus... Thanks will fix. > > > properties to also be set on the devices OF node. This mixes the > > Again, DT node? > > > properties of two distinctly different things and is confusing. > > > > This change adds support for an optional mdio node to be defined as a > > child to the device OF node. The child node can then be used to describe > > MDIO bus properties that the MDIO core can act on when registering the > > bus. > > > > If no mdio child node is found the driver fallback to the old behavior > > and register the MDIO bus using the device OF node. This change is > > backward compatible with old bindings in use. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > > [...] > > MBR, Sergey -- Kind Regards, Niklas Söderlund