On 08/03/2024 18:18, Théo Lebrun wrote: > Add Mobileye EyeQ5 compatible. > FIFO depth shall not be passed; hardware can detect it. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. There is no subsystem as "qspi". Also order of tags is incorrect. > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index cca81f89e252..cf7abf48673a 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -61,6 +61,17 @@ allOf: > cdns,fifo-depth: > enum: [ 128, 256 ] > default: 128 > + - if: > + properties: > + compatible: > + contains: > + const: mobileye,eyeq5-ospi > + then: > + properties: > + cdns,fifo-depth: false > + else: > + required: > + - cdns,fifo-depth > > properties: > compatible: > @@ -74,6 +85,7 @@ properties: > - xlnx,versal-ospi-1.0 > - intel,socfpga-qspi > - starfive,jh7110-qspi > + - mobileye,eyeq5-ospi So everyone adds at the end... Please put it after amd. With subject fixed and above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
