There's a pull-up missing on a pin that is used as GPIO input for PCIe which will make the diode/level-shifter not let voltage pass and thus not allowing the state of the pin to change. Also add the missing regulators for the PCIe PHY+connector though this is purely cosmetic. There's also a missing PU on the USB ID pin used as a GPIO input, so let's add it for the same reasons as the one used for PCIe listed above. Note there's a light dependency on https://lore.kernel.org/linux-rockchip/43d84aa9-ce0f-406e-82ac-2a691264ee23@xxxxxxxxxxxxxxxxxxxxx/T/#ma0499cbc5e5c20f1a4c6b8452baa2d296abe2d0d to prevent a git conflict for the maintainer(s). Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx> --- Quentin Schulz (3): arm64: dts: rockchip: enable internal pull-up on Q7_USB_ID for RK3399 Puma arm64: dts: rockchip: enable internal pull-up on PCIE_WAKE# for RK3399 Puma arm64: dts: rockchip: add regulators for PCIe on RK3399 Puma Haikou .../arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 33 +++++++++++++++++++++- 2 files changed, 34 insertions(+), 1 deletion(-) --- base-commit: 370e52abbf8306f09b0022995ad7ccdff3a834bb change-id: 20240308-puma-diode-pu-1d2f4551be6d Best regards, -- Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx>
